From ac96c35230f4e706452eafddcd7d972a1170094d Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Mon, 17 Mar 2014 15:00:45 -0400 Subject: [PATCH] Update documentation about link styling The ::link-color and ::visited-link-color style properties are ignored now. Document that. --- gtk/gtklabel.c | 13 +++++-------- gtk/gtkwidget.c | 6 ++++++ 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/gtk/gtklabel.c b/gtk/gtklabel.c index fcbd016675..e593517168 100644 --- a/gtk/gtklabel.c +++ b/gtk/gtklabel.c @@ -265,12 +265,9 @@ struct _GtkLabelPrivate * to ensure that pressing inside a link and releasing outside of it * does not activate the link. * - * Links are rendered with the link-color/visited-link-color colors - * that are determined by the style and with an underline. When the mouse - * pointer is over a link, the pointer is changed to indicate the link, - * and the background behind the link is rendered with the base[PRELIGHT] - * color. While a button is pressed over a link, the background is rendered - * with the base[ACTIVE] color. + * Links are rendered with the #GTK_STATE_FLAG_LINK/#GTK_STATE_FLAG_VISITED + * state flags. When the mouse pointer is over a link, the pointer is changed + * to indicate the link. * * Labels with links accept keyboard focus, and it is possible to move * the focus between the embedded links using Tab/Shift-Tab. The focus @@ -930,8 +927,8 @@ gtk_label_class_init (GtkLabelClass *class) * GtkLabel:track-visited-links: * * Set this property to %TRUE to make the label track which links - * have been clicked. It will then apply the ::visited-link-color - * color, instead of ::link-color. + * have been visited. It will then apply the #GTK_STATE_FLAG_VISITED + * when rendering this link, in addition to #GTK_STATE_FLAG_LINK. * * Since: 2.18 */ diff --git a/gtk/gtkwidget.c b/gtk/gtkwidget.c index 1d91ab056a..9541e596e2 100644 --- a/gtk/gtkwidget.c +++ b/gtk/gtkwidget.c @@ -3499,6 +3499,9 @@ G_GNUC_END_IGNORE_DEPRECATIONS * The "link-color" style property defines the color of unvisited links. * * Since: 2.10 + * + * Deprecated: 3.12: Links now use a separate state flags for selecting + * different theming, this style property is ignored */ gtk_widget_class_install_style_property (klass, g_param_spec_boxed ("link-color", @@ -3513,6 +3516,9 @@ G_GNUC_END_IGNORE_DEPRECATIONS * The "visited-link-color" style property defines the color of visited links. * * Since: 2.10 + * + * Deprecated: 3.12: Links now use a separate state flags for selecting + * different theming, this style property is ignored */ gtk_widget_class_install_style_property (klass, g_param_spec_boxed ("visited-link-color", -- 2.30.2